Exo2 2 #11
Open
Exo2 2 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge et jamais de decryptage.
pymaldebaran
requested changes
Dec 5, 2020
|
|
||
|
|
||
| def crack_key(cypher_text: str) -> int: | ||
| """Finde key""" |
There was a problem hiding this comment.
On va essayer d'éméliorer cette docstring... elle est pas là juste pour décorer !
| """Finde key""" | ||
| ALPHABET = list(string.ascii_uppercase) | ||
| CYPHER_TEXT = list(cypher_text) | ||
| list_occurence_by_letter = [] |
There was a problem hiding this comment.
On évite généralement de mettre le type d'une variable dans son nom (car souvent au cours de la vie d'un code, on change les types !)
| CYPHER_TEXT = list(cypher_text) | ||
| list_occurence_by_letter = [] | ||
| for letter in ALPHABET: | ||
| occurrence = CYPHER_TEXT.count(letter) |
There was a problem hiding this comment.
Très bonne idée d'utiliser count 👍
| INDEX_LETTER_MOST_OCCURENCE = list_occurence_by_letter.index( | ||
| max(list_occurence_by_letter) | ||
| ) | ||
| LIKELY_TO_BE_E = ALPHABET[INDEX_LETTER_MOST_OCCURENCE] |
There was a problem hiding this comment.
Cette ligne est super belle 👍
|
|
||
|
|
||
| def do_decipher(cypher_text: str, key: int) -> str: | ||
| """Decipher text """ |
There was a problem hiding this comment.
Comme pour l'autre fonction : il faudrait améliorer cette docstring. Genre au moins dire qu'onle fait avec la clé...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.